Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry block example in README is incorrect #11

Closed
justinlittman opened this issue Aug 5, 2022 · 1 comment · Fixed by #12
Closed

Retry block example in README is incorrect #11

justinlittman opened this issue Aug 5, 2022 · 1 comment · Fixed by #12

Comments

@justinlittman
Copy link
Contributor

In particular, it references retries_remaining instead of retry_count in /~https://github.com/lostisland/faraday-retry#call-a-block-on-every-retry

Should be:

response_statuses = []
retry_options = {
  retry_block: -> (env:, options:, retry_count:, exception:, will_retry_in:) { response_statuses << env.status }
}
@olleolleolle
Copy link
Member

@justinlittman Cool! Would you like to make a PR?

justinlittman added a commit to justinlittman/faraday-retry that referenced this issue Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants