Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cx16] Add missing asm sections and progbits #369

Merged
merged 2 commits into from
Sep 19, 2024
Merged

[cx16] Add missing asm sections and progbits #369

merged 2 commits into from
Sep 19, 2024

Conversation

mlund
Copy link
Contributor

@mlund mlund commented Aug 26, 2024

No description provided.

@mlund
Copy link
Contributor Author

mlund commented Aug 27, 2024 •
edited
Loading

I just read the wiki and realise that R means retain and not read-only. I guess we don't want that(?)

@mysterymath
Copy link
Member

mysterymath commented Sep 16, 2024 •
edited
Loading

I just read the wiki and realise that R means retain and not read-only. I guess we don't want that(?)

That's right, the only things that should be marked R are those sections where it would be incorrect for the linker to ever remove them, even if completely unreferenced.

@mysterymath mysterymath merged commit 823135e into llvm-mos:main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysterymath mysterymath mysterymath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlund @mysterymath