Split neslib and nesdoug components so they are linked conditionally #217
Conversation
The following components are only linked in if used (including any data, init/nmi routines, etc.): - vram update (aka name_upd) - OAM_BUF - PAL_BUF - pal_bright
Nitpick, if you say the "Fixes" instead of "Addresses", Github will automatically close the issue on merge; very nice to have. EDIT: That list is quite long, you just happened to choose a word that isn't on it. I blame the list, get the thesaurus! |
This is very on-brand for me. >< |
mos-platform/nes/neslib/ntsc.s
Outdated
| @@ -3,9 +3,15 @@ | |||
| .include "ntsc.inc" | |||
| .include "neslib.inc" | |||
|
|
|||
| .section .init.275,"axR",@progbits | |||
| .section .init.330,"axR",@progbits | |||
There was a problem hiding this comment.
We should maintain the property that the neslib initializers are done before .init.300; that's when user-defined module level constructors fire, and broadly anything that is accessible in C should work properly from those pre-main constructors, including the NTSC mode.
This is true here and throughout this file; anything that previously occurred before .init.300 should stay before .init.300.
There was a problem hiding this comment.
looks like i forgot to include mos-platform/common when I was searching for existing init ranges.
…ionally (#217)" This reverts commit 55051dd. I gave this a quick spin-through compiling /~https://github.com/mysterymath/nesdoug/26_Full_Game, and this change causes it to immediately present "You Died" after hitting Start. Not sure exactly what changed, but it looks like this introduces some kind of significant behavioral change.
|
Unfortunately, I ended up having to revert this; see the above commit message for details. |
…ditionally (llvm-mos#217)" This reverts commit 2207d5a.
Fixes #214