🦺[Tech debt] Refactor send class #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This method had `launchOptions` that was never used.
kcw-grunt
added a commit
that referenced
this pull request
Aug 24, 2021
* Removed the launch options - This method had `launchOptions` that was never used. * Removed all unused code.
kcw-grunt
added a commit
that referenced
this pull request
Aug 25, 2021
* updated to the latest API library - Moved to v0.8.0 * Remove (swiftch off) code coverage - There is a bug in Xcode where running code coverage breaks the SwiftUI canvas * Added the basic localization - Pre-polish the languiage and the translations - Tech Debt: Code clean up - Deleted and cleaned up files. * Updated the CardViewController - UIKit updated relative to the modal * First version of 2FA working - New 2FA View - New 2FA Model * Cleaned up code formatting * Polished the events and notes * Added 2FA text Localizations: * 2FA Not Enabled * 2FA Enabled * Enter the code that was recently sent to your Litecoin Card account email. * Enter Code * Confirm * Added tests - Stubbed in the View Extenstion tests - Enable2FAViewModel tests * Resolved per PR notes * Restruct localizations (#83) - Turkish is now found * 🦺[Tech debt] Refactor send class (#80) * Removed the launch options - This method had `launchOptions` that was never used. * Removed all unused code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Removing code in the Send class and the Application Controller
Why?
We need to remove unused code