Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed to match iosdev #74

Merged
merged 6 commits into from
Jul 6, 2021
Merged

Changed to match iosdev #74

merged 6 commits into from
Jul 6, 2021

Conversation

kcw-grunt
Copy link
Contributor

No description provided.

@JCHeist
Copy link
Contributor

JCHeist commented Jul 5, 2021

  1. I have edited the workspace file because the workspace is not setup for new devs And it is not gitignored. I added the litewallet and pods project to the workspace so that whomever can dev on the workspace rather than the project itself. Would only be necessarry in our code base if one of us needed to edit the podfile though I suppose.

  2. A few other workspace shared files that dont exist in our source control though we have not elected to ignore them. I imagine your git source control application, git tower is ignoring these things be default.

@kcw-grunt

@JCHeist JCHeist self-requested a review July 5, 2021 22:23
@JCHeist JCHeist marked this pull request as ready for review July 5, 2021 22:23
@kcw-grunt kcw-grunt merged commit 113e9fc into develop Jul 6, 2021
@kcw-grunt
Copy link
Contributor Author

NOOOOICE

@kcw-grunt kcw-grunt deleted the techdebt/gitignore-cleanup branch July 6, 2021 19:18
@kcw-grunt kcw-grunt mentioned this pull request Jul 16, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCHeist JCHeist JCHeist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcw-grunt @JCHeist