Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲[Techdebt] polish layout fees #229

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

kcw-grunt
Copy link
Contributor

What?

There was a minor bug where the ops address would show up instead of the sent address. Also the fees were off by a factor

Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>
Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>
TIME:  1707828867
Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>
Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>
Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>
@kcw-grunt kcw-grunt added the 🦟 critical bug Drop everything. this bug needs immediate attention label Feb 14, 2024
@kcw-grunt kcw-grunt added this to the Release v3.12.1 milestone Feb 14, 2024
@kcw-grunt kcw-grunt requested a review from josikie February 14, 2024 01:38
Copy link

@josikie josikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thank you!
What is ops address? What is the difference between ops address and send address?

@kcw-grunt
Copy link
Contributor Author

Cool! Thank you! What is ops address? What is the difference between ops address and send address?

The ops address is the address users are sending the service fee. It is the way we are funding the MWEB, redesign and staff grants

@kcw-grunt
Copy link
Contributor Author

@josikie TYVM

@kcw-grunt kcw-grunt merged commit 316108d into release/v3.12.1 Feb 14, 2024
1 check failed
@kcw-grunt kcw-grunt deleted the techdebt/polish-layout-fees branch May 11, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦟 critical bug Drop everything. this bug needs immediate attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants