Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #2494

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix bug #2494

merged 2 commits into from
Dec 16, 2024

Conversation

Johnson-zs
Copy link
Contributor

No description provided.

Add encryption feature flag check using config_utils::enableEncrypt()
before registering disk encryption menu scene to prevent unnecessary
menu initialization when encryption is disabled.

Log:

Bug: https://pms.uniontech.com/bug-view-295323.html
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • plugin_diskencryptentry.cpp文件中新增了encryptutils.h头文件,但未提供对应的实现或说明其用途。
  • start函数中新增了一个条件判断,如果加密功能未启用,则直接返回true,这可能是一个逻辑错误,因为通常情况下,如果功能未启用,应该返回false或抛出异常。

是否建议立即修改:

Copy link

TAG Bot

TAG: 6.5.17
EXISTED: no
DISTRIBUTION: unstable

@Johnson-zs
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 16, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 3b586e2 into linuxdeepin:master Dec 16, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants