Classify some gRPC status codes as non-errors #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Nov 18, 2019
tegioz
force-pushed
the
tegioz/grpc-success-status-codes
branch
from
108fb5f to
e2e66f1
Compare
adleong
reviewed
Nov 26, 2019
adleong
approved these changes
Nov 26, 2019
|
It seems to me that other grpc status codes should not be considered errors as well. In fact, it seems like only a few should be considered errors: /~https://github.com/grpc/grpc/blob/master/doc/statuscodes.md Specifically, UNAVAILABLE and INTERNAL seem to be clear errors. I'm not sure that any of the other error codes actually correspond to 5XX server failures. |
Signed-off-by: Sergio Castaño Arteaga <tegioz@icloud.com>
tegioz
force-pushed
the
tegioz/grpc-success-status-codes
branch
from
e2e66f1 to
53ab87d
Compare
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Dec 18, 2019
This release adds a defense mechanism to ensure that resolutions are released when the associated balancer becomes idle and should have been dropped from the proxy. Furthermore, the proxy is now more selective as to which gRPC status codes are considered "failures" in metrics. --- * Classify some gRPC status codes as non-errors (linkerd/linkerd2-proxy#395) * discover: Timeout stalled resolutions (linkerd/linkerd2-proxy#401)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Dec 19, 2019
This release adds a defense mechanism to ensure that resolutions are released when the associated balancer becomes idle and should have been dropped from the proxy. Furthermore, the proxy is now more selective as to which gRPC status codes are considered "failures" in metrics. --- * Classify some gRPC status codes as non-errors (linkerd/linkerd2-proxy#395) * discover: Timeout stalled resolutions (linkerd/linkerd2-proxy#401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linkerd classifies all gRPC status codes except
OKas errors. This can negatively affect a gRPC server's success rate, even when it is only returning things likeNOT_FOUNDorINVALID_ARGUMENT.This change narrows down the list of gRPC status codes that are considered an error to:
Please see this linkerd2 issue for more details.
Signed-off-by: Sergio Castaño Arteaga tegioz@icloud.com