Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DbFactory #16

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Fix DbFactory #16

merged 1 commit into from
Dec 10, 2022

Conversation

Gillingham
Copy link
Contributor

The filename is PdoDB.php so we need to handle that, and use an uppercase 'DB' when calling the className. Alternatively, the PdoDB file could be renamed, but I'm sure which you would prefer.

The filename is `PdoDB.php` so we need to handle that, and use an uppercase 'DB' when calling the className.
Alternatively, the PdoDB file could be renamed, but I'm sure which you would prefer.
@linc linc merged commit 2883fe9 into linc:main Dec 10, 2022
@linc
Copy link
Owner

linc commented Dec 10, 2022

Thank you!

Note for future reference: The issue here is that while classes are case-insensitive, the autoloader can be case sensitive when the class hasn't loaded yet because file_exists() is case-sensitive. I obviously never hit that scenario in my testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants