Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS] Fix templating extension "filter" return type #951

Merged
merged 1 commit into from
Jun 20, 2017
Merged

[CS] Fix templating extension "filter" return type #951

merged 1 commit into from
Jun 20, 2017

Conversation

imanalopher
Copy link
Contributor

Q A
Branch? 1.0 or 2.0
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Deprecations? yes/no
Tests pass? yes/no
Fixed tickets
License MIT
Doc PR

@robfrawley robfrawley added Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality. Type: Documentation This item pertains to documentation of this project. State: Reviewing This item is being reviewed to determine if it should be accepted. labels Jun 19, 2017
@robfrawley robfrawley added this to the 1.8.1 milestone Jun 19, 2017
@alexwilson
Copy link
Collaborator

Oof good catch. I guess the Twig_Markup is vestigial?

@alexwilson alexwilson self-requested a review June 20, 2017 07:56
@cedricziel cedricziel merged commit 6e43896 into liip:1.0 Jun 20, 2017
@imanalopher
Copy link
Contributor Author

Thanks guys!!!

@robfrawley robfrawley changed the title return filter function String [CS] Fix templating extension "filter" return type Jul 13, 2017
@robfrawley robfrawley mentioned this pull request Aug 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwilson alexwilson alexwilson approved these changes

@cedricziel cedricziel cedricziel approved these changes

Assignees
No one assigned
Labels
Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality. State: Reviewing This item is being reviewed to determine if it should be accepted. Type: Documentation This item pertains to documentation of this project.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@imanalopher @alexwilson @cedricziel @robfrawley