Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Enable mongo unit tests on PHP7 using "mongo" => "mongodb" extension adapter #882

Merged
merged 1 commit into from
Feb 27, 2017
Merged

[Tests] Enable mongo unit tests on PHP7 using "mongo" => "mongodb" extension adapter #882

merged 1 commit into from
Feb 27, 2017

Conversation

robfrawley
Copy link
Collaborator

@robfrawley robfrawley commented Feb 23, 2017 •
edited
Loading

Q A
Branch? 1.0
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Use the alcaeus/mongo-php-adapter package during Travis builds to provide an adapter for the mongo extension (not compatible with PHP7) that proxies calls to the new mongodb extension (compatible with PHP7), allowing for MongoDB-related code to be properly tested on all PHP engines. Also included is general cleanup of the composer.json file.

@robfrawley robfrawley added Level: Enhancement ✨ This item involves an enhancement to existing functionality. State: Confirmed This item has been confirmed by maintainers as legitimate. labels Feb 23, 2017
@robfrawley robfrawley added this to the 1.7.3 milestone Feb 23, 2017
@robfrawley robfrawley self-assigned this Feb 23, 2017
@lsmith77 lsmith77 added State: Reviewing This item is being reviewed to determine if it should be accepted. and removed State: Confirmed This item has been confirmed by maintainers as legitimate. labels Feb 23, 2017
@robfrawley robfrawley added State: Confirmed This item has been confirmed by maintainers as legitimate. and removed State: Reviewing This item is being reviewed to determine if it should be accepted. labels Feb 23, 2017
@robfrawley robfrawley changed the title Run Mongo Tests on PHP7 and Cleanup composer.json [Travis] Run Mongo Tests on PHP7 and Cleanup composer.json Feb 26, 2017
@robfrawley robfrawley force-pushed the feature-mongo-php7-and-composer-cleanup branch from 44ec695 to 7be24b8 Compare February 27, 2017 06:00
@robfrawley robfrawley changed the title [Travis] Run Mongo Tests on PHP7 and Cleanup composer.json [Travis] Run MongoDB unit tests on PHP7 using "mongodb" extension adapter Feb 27, 2017
@robfrawley robfrawley changed the title [Travis] Run MongoDB unit tests on PHP7 using "mongodb" extension adapter [Travis] Enable mongo unit tests on PHP7 using "mongo" => "mongodb" extension adapter Feb 27, 2017
@robfrawley robfrawley merged commit de43101 into liip:1.0 Feb 27, 2017
@lsmith77 lsmith77 removed the State: Confirmed This item has been confirmed by maintainers as legitimate. label Feb 27, 2017
@robfrawley robfrawley changed the title [Travis] Enable mongo unit tests on PHP7 using "mongo" => "mongodb" extension adapter [Tests] Enable mongo unit tests on PHP7 using "mongo" => "mongodb" extension adapter Mar 1, 2017
@robfrawley robfrawley mentioned this pull request Mar 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricziel cedricziel Awaiting requested review from cedricziel

@alexwilson alexwilson Awaiting requested review from alexwilson

Assignees

@robfrawley robfrawley

Labels
Level: Enhancement ✨ This item involves an enhancement to existing functionality.
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@robfrawley @lsmith77