Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude "Tests" directory from classmap #835

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Exclude "Tests" directory from classmap #835

merged 1 commit into from
Dec 12, 2016

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Dec 8, 2016

No description provided.

@alexwilson
Copy link
Collaborator

alexwilson commented Dec 8, 2016 •
edited
Loading

I see you've created this PR across a bunch of bundles at once, cheers for taking care of that!

More details here if anybody is interested - Sylius/Sylius#7035

I'm very okay with this, to me the risk of BC is very low though it might be worth saving this for the next 1.0 minor release versus tagging as a patch. Just in case.
Definitely good to go in 2.0 IMO.

@alexwilson alexwilson added Level: Enhancement ✨ This item involves an enhancement to existing functionality. State: Reviewing This item is being reviewed to determine if it should be accepted. State: Confirmed This item has been confirmed by maintainers as legitimate. labels Dec 8, 2016
@pamil pamil changed the base branch from 1.0 to 2.0 December 8, 2016 11:05
@pamil pamil closed this Dec 8, 2016
@pamil pamil reopened this Dec 8, 2016
@lsmith77 lsmith77 removed State: Reviewing This item is being reviewed to determine if it should be accepted. State: Confirmed This item has been confirmed by maintainers as legitimate. labels Dec 8, 2016
@pamil
Copy link
Contributor Author

pamil commented Dec 8, 2016

Changed base branch, rerun Travis.

@robfrawley
Copy link
Collaborator

👍 for 2.0

@robfrawley robfrawley closed this Dec 9, 2016
@robfrawley
Copy link
Collaborator

Oops: didn't mean to close.

@robfrawley robfrawley reopened this Dec 9, 2016
@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Dec 9, 2016
robfrawley
robfrawley approved these changes Dec 11, 2016
View reviewed changes
Copy link
Collaborator

@robfrawley robfrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from my perspective for the 2.x branch

@robfrawley
Copy link
Collaborator

robfrawley commented Dec 11, 2016 •
edited
Loading

Anyone see any negative impact on this? Otherwise I submit we merge tomorrow.

@alexwilson
Copy link
Collaborator

I'm happy with that!

@robfrawley robfrawley merged commit 539ec6d into liip:2.0 Dec 12, 2016
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Dec 12, 2016
@alexwilson
Copy link
Collaborator

🎉

@pamil pamil deleted the patch-1 branch December 12, 2016 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robfrawley robfrawley robfrawley approved these changes

@alexwilson alexwilson alexwilson approved these changes

Assignees
No one assigned
Labels
Level: Enhancement ✨ This item involves an enhancement to existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pamil @alexwilson @robfrawley @lsmith77