List deprecation - closes #731 #787
Conversation
| [30, 0], | ||
| [null, 16], | ||
| [37, null], | ||
| [null, null] |
There was a problem hiding this comment.
This was never supported.
alexwilson
changed the title
alexwilson
force-pushed
the
list-deprecation
branch
from
198273d to
1c5c7b2
Compare
alexwilson
force-pushed
the
list-deprecation
branch
2 times, most recently
from
bb55608 to
079a0a5
Compare
alexwilson
force-pushed
the
list-deprecation
branch
from
079a0a5 to
ea3b297
Compare
| @@ -54,51 +54,51 @@ protected function createFilterConfiguration() | |||
|
|
|||
| protected function getMockCacheManager() | |||
| { | |||
| return $this->getMock('Liip\ImagineBundle\Imagine\Cache\CacheManager', array(), array(), '', false); | |||
| return $this->getMockBuilder('Liip\ImagineBundle\Imagine\Cache\CacheManager')->getMock(); | |||
There was a problem hiding this comment.
So happy someone is taking the time to update the test suite to remove PHPUnit 5.x deprecations. I have a similar branch that removes all getMock methods in favor of getMockBuilder. I'll wait until this is merged to submit my PR for this.
alexwilson
force-pushed
the
list-deprecation
branch
4 times, most recently
from
9f55b5d to
de354bd
Compare
alexwilson
force-pushed
the
list-deprecation
branch
from
de354bd to
91ee4c8
Compare
|
I'll defer writing the appropriate documentation until after #789 is merged, there should not be much of it. As a follow-up to this I may submit further PRs focusing purely on test coverage. |
alexwilson
changed the title
|
What do you think @lsmith77 / @robfrawley ? |
|
@antoligy Looks great to me. New tests introduced increase total test coverage from 61.6% to 65.4% --- and increases total test coverage of 👍 |
|
Yeah thanks that feels pretty good! I might have another pass at writing some tests to further increase Loader coverage as there's definitely a few easy wins in there, but that I can do irrespective of this PR. The goal here was to remove |
|
Adding cross-reference to issue #731 (issues in titles don't create cross-reference links). |
| { | ||
| $this->dimentionKey = $dimentionKey; |
There was a problem hiding this comment.
@antoligy Wow, can't believe we had filters creating dynamic class properties...
There was a problem hiding this comment.
Oh, it still does, I plan on restructuring this at a later date - The ScaleFilter is inherited by the DownscaleFilter and UpscaleFilter both of which use slightly different parameters.
|
Paging dr @lsmith77 😄 |
list(), due to its unpredictable nature between different versions of PHP.