Replaced deprecated factory_class and factory_method

[rvanlaarhoven]

Removed the deprecated factory_class and factory_method service definition options and replaced them with the factory option.

Should I also still reference the old way for Symfony <2.6 usage?

[alexwilson]

Hey, thanks for this!

I think BC with older versions of Symfony is still a concern, so it might be worth preserving until the next major version of this bundle.

What are your thoughts @lsmith77 ?

[lsmith77]

I am ok bumping the symfony dependency to the oldest release that still gets security updates.

[lsmith77]

ping

[robfrawley]

I second bumping this minimum Symfony version and fixing the YAML/XML/etc factory definitions.

[alexwilson]

@lsmith77 - Security updates are provided until EOL, which currently means that security updates will be provided for 2.3 until May 2017.
Given #728, should we raise the required version to 2.8 and merge this into the 2.0 branch as the first of hopefully many improvements?

@rvanlaarhoven Hey are you still around to make this change? If not, would you accept a PR to your remote / Allow one of us to re-raise this PR with the appropriate additions?

[rvanlaarhoven]

Yep, still around. And would also accept PR's to my fork.

[alexwilson]

Actually that might not need to happen anymore! /~https://github.com/blog/2247-improving-collaboration-with-forks 😄

[robfrawley]

@lsmith77 The decision on this was not to drop Symfony 2.3 support in the current 1.x release, correct? Should we set the milestone for this to the 2.x branch where we can drop Symfony 2.3 support.

[robfrawley]

@antoligy: 👍