Fix broken CacheResolver tests (#650) #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since September'2015 Doctrine doesn't always save namespace version in the cache itself: doctrine/cache@ecc4af1 Relying on such kind of implementation detail in a test that is supposed to check if several keys are saved in a cache is kind of pointless, so it makes sense to ignore the cache key that holds a namespace version
kamazee
force-pushed
the
fix_cache_resolver_tests
branch
from
05a3c89 to
785a0d1
Compare
|
can you look at the prefer-lowest test too? https://travis-ci.org/liip/LiipImagineBundle/jobs/88415483 |
|
So, when this PR and #657 are merged together, the build should get green. I'll probably put them together and create a dummy PR with both commits just to make Travis build them both and check my assumption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #650
Since September'2015 Doctrine doesn't always save namespace version in
the cache itself
Relying on such kind of implementation detail in a test that is supposed to check if several keys are saved in cache is kind of pointless, so it makes sense to ignore the cache key that holds a namespace version -- that's exactly what's implemented in the PR.