-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the new quality options #473
Conversation
needs a rebase .. also tests would be good. |
We really need this feature but I am not sure about the implementation. |
Rebased. However I am not sure if unit test is any helpful since these options are just passed own to imagine. |
hm, the PR looks unfinished. there is not any tests and you just defined properties but do not use them anywhere |
@makasim this PR just adds options for Imagine, so they are passed along with the other options. @patrickli in terms of tests you just need to ensure that they are properly set /~https://github.com/liip/LiipImagineBundle/tree/master/Tests/DependencyInjection |
@lsmith77 thanks for the explanation |
Unit test added. |
Add support for the new quality options
@patrickli thanks |
This adds support for the following new quality options: