Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new quality options #473

Merged
merged 3 commits into from
Jan 31, 2015
Merged

Add support for the new quality options #473

merged 3 commits into from
Jan 31, 2015

Conversation

patrickli
Copy link

This adds support for the following new quality options:

  • jpeg_quality
  • png_compression_level
  • png_compression_filter

@lsmith77 lsmith77 added the Level: New Feature 🆕 This item involves the introduction of new functionality. label Jan 8, 2015
@lsmith77
Copy link
Contributor

lsmith77 commented Jan 8, 2015

needs a rebase .. also tests would be good.

@makasim
Copy link
Collaborator

makasim commented Jan 8, 2015

We really need this feature but I am not sure about the implementation.

@patrickli
Copy link
Author

Rebased. However I am not sure if unit test is any helpful since these options are just passed own to imagine.

@makasim
Copy link
Collaborator

makasim commented Jan 30, 2015

hm, the PR looks unfinished. there is not any tests and you just defined properties but do not use them anywhere

@lsmith77
Copy link
Contributor

@makasim this PR just adds options for Imagine, so they are passed along with the other options.

@patrickli in terms of tests you just need to ensure that they are properly set /~https://github.com/liip/LiipImagineBundle/tree/master/Tests/DependencyInjection

@makasim
Copy link
Collaborator

makasim commented Jan 30, 2015

@lsmith77 thanks for the explanation

@patrickli
Copy link
Author

Unit test added.

makasim added a commit that referenced this pull request Jan 31, 2015
Add support for the new quality options
@makasim makasim merged commit 2779907 into liip:master Jan 31, 2015
@makasim
Copy link
Collaborator

makasim commented Jan 31, 2015

@patrickli thanks

@patrickli patrickli deleted the new-quality-options branch February 1, 2015 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants