support animated gif #466
support animated gif #466
Conversation
|
should not we take the value from config, like we do for the |
|
updated the code to support animated value from config. default value is false. |
|
squashed commits and rebased on top of master |
| )); | ||
| ); | ||
|
|
||
| if ($binary->getFormat() === 'gif' && $config['animated']) { |
There was a problem hiding this comment.
should we force it? what if we set it for no gif images, what would be get?
There was a problem hiding this comment.
What do you mean by "force it"? I have no idea if its working with non-gif-images...
There was a problem hiding this comment.
the idea is to get the value from the config, here for the gif you always force it to be true. I think has to be taken as is from the config and any assumptions are done.
There was a problem hiding this comment.
Ah got it. fixed with the latest push.
animated value from config
|
Its waiting for php-imagine/Imagine#348 to get merged. Or did I misunderstood your question? |
|
It not works for me. My setup is: scuben/Imagine:dev-resize-animated-gif and liip/imagine-bundle:dev-master. I have set animated option to true in my config. Is this supposed to work? |
|
Would love to get this implemented. Would be good if everyone could bump the imagine PR ;) |
This PR prepares LiipImageBundle to support animated GIF in the future. Next on my todo list is a PR on Imagine.
Imagine PR php-imagine/Imagine#348