[1.0][CacheResolver] Use binary on store method call.

[makasim]

Annnnd finally we decouple the bundle logic from http response\request.

[makasim]

@havvg ready for review

[havvg]

Yes, an exception should be thrown here, what about a Liip\ImagineBundle\Exception\Imagine\Cache\Resolver\StoreBinaryException?

In regards to making this an error state that is not handled by the resolver itself anymore, the log entry should be error instead of warning (same applies to AwsS3Resolver).

[makasim]

I want to find a shorter exception name\namespace. Thinking....

[havvg]

The sub-namespace in Liip\ImagineBundle\Exception is derived from the actual namespace of the resolvers. However I'm open to a better concept :)

[makasim]

@havvg what about Liip\ImagineBundle\Exception\Imagine\Cache\Resolver\NotStorableException like we have NotResolableException ?

[makasim]

@havvg I fixed your comments, new changes:

• NullLogger created in constructor, it allows to remove if $this->logger statement on each use of logger
• AmazonS3Resolver and AwsS3Resolver now implements LoggerAwareInterface.

[havvg]

+1 :)

[makasim]

@havvg fix assertNull and warning comments.

[havvg]

The changes on the NullLogger now make the S3 resolvers depend on the psr/log package, so the package should at least be added to composer.json suggest section.

[makasim]

@havvg it is already required

[havvg]

Ah, I missed that one. However it's not required as it, but an optional dependency when using either of the S3 resolvers, so let's move it to suggest and keep it in require-dev.

[makasim]

@havvg I decided to revert NullLogger and LoggerAwareItnerface changes. Though I moved psr\log to require-dev and monolog\monolog to suggest.