Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Twig package in the required dependencies #1273

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Specify Twig package in the required dependencies #1273

merged 2 commits into from
Jun 25, 2020

Conversation

emulienfou
Copy link
Contributor

Q A
Branch? 2..x/master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1272
License MIT

Add missing required version of twig/twig package.
Due to the use of apply tag, Twig package versions need to be added.

According to the Twig documentations here:

Twig required versions are: 1.40, 2.9 and 3.0.

Copy link

@Tobion Tobion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think twig was meant as an optional dependency which is why it wasn't required. People could use php templating instead. But since php templating has been removed almost in newer symfony versions, it seems fine to require twig here.

@dbu dbu merged commit 5c98c91 into liip:master Jun 25, 2020
@dbu
Copy link
Member

dbu commented Jun 25, 2020

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants