Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass catched exception to give more insight on the original problem #1262

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Pass catched exception to give more insight on the original problem #1262

merged 1 commit into from
Jan 23, 2020

Conversation

pyrech
Copy link
Contributor

@pyrech pyrech commented Jan 23, 2020

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

IMHO every caught exception should always be passed to any new exception thrown.
Without this change, I would have never guessed that I was missing a PHP extension 😅

dbu
dbu approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, thanks for the fix

@dbu dbu merged commit 3fc8732 into liip:master Jan 23, 2020
@pyrech pyrech deleted the pass-exception branch January 23, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@ternel ternel ternel approved these changes

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pyrech @dbu @ternel @lyrixx