Fix RemoveCacheCommand with empty path #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
fix_remove_cache_command
branch
from
664dcce to
e9548e9
Compare
franmomu
force-pushed
the
fix_remove_cache_command
branch
from
e9548e9 to
2211cf2
Compare
|
Thanks a lot for this fix! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1222 the
pathforRemoveCacheCommandwas made mandatory, so there is no way to remove all images and filters as before.As paths can be multiple I changed it back to
paths.I don't like very much the solution because if you execute the command you would get:which is a little bit weird, soany suggestion is more than welcome.Now it says: