[Tests] [Deprecation] Updated bundle notation to accommodate Symfony 4.1 and set browser client to not catch exceptions #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anged browser kit client to not catch exceptions to fix our test suite. References: - https://symfony.com/blog/new-in-symfony-4-1-deprecated-the-bundle-notation - symfony/symfony#26085 - symfony/symfony#22890 Signed-off-by: Rob Frawley 2nd <rmf@src.run>
robfrawley
added
Level: Bug 🐞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0This PR changes the bundle notation to the fully qualified service name followed by a double colon and the action name. Symfony 4.1 deprecated single colon usage, creating a situation where it was impossible to support pre- and post-4.1 without deprecations if the syntax was not changed. This change required moving to the new service id/class naming conventions and creating a
liip_imagine.controlleralias.Also, somewhere along the lines the client browser (used in tests) stopped throwing exceptions and began catching them; its configuration was changed to allow exceptions to be thrown through for tests.
Lastly, the
2.0.0release was intended to target Symfony >=3.4, but this was never memorialized in the composer configuration.References: