[Dependency Injection] Detect proper web root path based on Symfony kernel version #1044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0
Enable dynamic default configuration values for the following configuration entries:
liip_imagine.loaders.<name>.filesystem.data_root
liip_imagine.resolvers.<name>.web_path.web_root
The folder layout for the web root directory changed between Symfony
3.x
(%kernel.project_dir%/web
) and4.x
(%kernel.project_dir%/public
). This PR implements an alternate to #1039 as discussed there, where the DI factories dynamically assign the default values based on the Symfony kernelVERSION_ID
. All documentation and tests were also amended to accommodate the aforementioned changed.Additional changes, outside the scope of this titled PR, are:
SymfonyFramework::kernelVersionCompare()
method implementation.SymfonyFramework
.