BOLT 1: define what offered and negotiated mean.
#1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. it was present in the init feature bits. We use this in several places, but assume everyone knows what it means. It's particularly fraught with required features: it's explicitly legitimate to assume these are accepted if the node keeps talking to you after init! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
|
We don't have such code in eclair yet, if our peer sets a feature bit as mandatory that we don't set, we always disconnect. |
ProofOfKeags
approved these changes
Sep 15, 2023
24 tasks
22 tasks
This is also lnd's behavior. |
t-bast
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. it was present in the init feature bits. We use this in several places, but assume everyone knows what it means.
It's particularly fraught with required features: it's explicitly legitimate to assume these are accepted if the node keeps talking to you after init!