Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrations disabling token creation and minting #420

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented Apr 24, 2024

This PR provides migrations to disable token creation and minting with respective resiliency tests.

The migrations should be activated when the time comes to migrate to the MANIFEST chain.

@fmorency fmorency self-assigned this Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.67%. Comparing base (5166a41) to head (01ea915).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/many-ledger/src/module/ledger_mintburn.rs 66.66% 3 Missing ⚠️
src/many-ledger/src/module/ledger_tokens.rs 66.66% 3 Missing ⚠️
.../many-ledger/src/migration/disable_token_create.rs 0.00% 1 Missing ⚠️
...rc/many-ledger/src/migration/disable_token_mint.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   81.69%   81.67%   -0.03%     
==========================================
  Files         149      151       +2     
  Lines       16817    16837      +20     
==========================================
+ Hits        13739    13751      +12     
- Misses       3078     3086       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmorency fmorency requested a review from jgryffindor April 25, 2024 13:56
@fmorency fmorency added the enhancement New feature or request label Apr 25, 2024
@fmorency fmorency marked this pull request as ready for review April 25, 2024 13:56
@fmorency
Copy link
Contributor Author

Disregard codecov complains; resiliency tests cover those migrations.

Copy link

@jgryffindor jgryffindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good in QA!

image

@fmorency fmorency merged commit 6818b55 into liftedinit:main Oct 16, 2024
5 of 6 checks passed
@fmorency fmorency deleted the token-migration branch October 16, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants