Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-toolkit): update info and links in package.json files #131

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

wincent
Copy link
Contributor

@wincent wincent commented Oct 6, 2020

  • Remove stuff that doesn't make sense in private packages because they never get published to the registry (ie. anything with links). Likewise, we remove the "workspaces" from "projects/js-toolkit/package.json" because it is now participating in the monorepo's top-level workspaces configuration. I didn't touch the 2.x equivalent under "maintenance/projects/js-toolkit" because that one is using its own workspace set-up.
  • Add "author" to all public packages.
  • Add "repository" info to all public packages.

Not sorting the keys yet, but will do that in a separate PR, for consistency with all the other package.json in the monorepo.

- Remove stuff that doesn't make sense in private packages because they
  never get published to the registry (ie. anything with links).
  Likewise, we remove the "workspaces" from
  "projects/js-toolkit/package.json" because it is now participating
  in the monorepo's top-level workspaces configuration. I didn't touch
  the 2.x equivalent under "maintenance/projects/js-toolkit" because
  that one _is_ using its own workspace set-up.
- Add "author" to all public packages.
- Add "repository" info to all public packages.

Not sorting the keys yet, but will do that in a separate PR, for
consistency with all the other package.json in the monorepo.
@wincent
Copy link
Contributor Author

wincent commented Oct 6, 2020

"No logic changes", so I'm going to get this in in order to continue building on top of it. If I broke anything will follow-up with a fix.

@wincent wincent merged commit ae60f4e into master Oct 6, 2020
@wincent wincent deleted the wincent/package-json-updates branch October 6, 2020 15:21
wincent added a commit that referenced this pull request Dec 18, 2020
…roperties

docs(ccp): moved documentation to dxp section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant