-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys.cpp: fix code fallbacks for older Darwin #739
Conversation
Failure on Ubuntu CI is irrelevant:
|
@kris-rowe I think I have missed this. Was there some special reason to have it broken back? The change from 3cba084 looks wrong. I guess, instead a macro should be moved, so that we have MacOS fixed again, but without affecting anything else. |
I have a feeling it broke the GitHub CI testing for Linux. The updates in #758 look like good and handle all cases. |
Not sure why it was conditioned on Clang at all, since
clock_gettime
is provided by SDK and not compiler. Fix that.Include
AvailabilityMacros.h
– apparently nothing in the codebase does that (or did I miss it?).Amend fallback code for threadid for older macOS.