[NavSvc] make INavigationService.Navigate*()
accepts dataContext
as argument
#944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
INavigationService
lacks a way to specifydataContext
for navigating.Yes, we can get the underlying
NavigationControl
and navigate withdataContext
object like this:but... that's a bit tedious.
Issue Number: N/A
What is the new behavior?
add these 3 overload methods with
dataContext
toINavigationService
so client code can just do
NavigationService.Navigate(type, data)
without the hassle.Other information
However, if the current displaying page (ie. top-most navigation stack) is
pageType
,Navigate*(...)
returnsfalse
and does nothing.I managed to force-refresh the stack by doing this in client code: