Updated schema #48
Merged
Updated schema #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexios80
reviewed
May 18, 2024
|
|
||
| /// Package Score Model | ||
| class PackageScore { | ||
| final int? grantedPoints; |
There was a problem hiding this comment.
@leoafarias Why were these changed to non-nullable? Are we sure these are never null?
There was a problem hiding this comment.
Yes they come nullable if the package is processing.
There was a problem hiding this comment.
Shouldn't they be changed back to nullable then?
There was a problem hiding this comment.
Sorry for the confusion. They used to be nullable before, but on my tools, they are not anymore. Let me know if you are seeing something different.
There was a problem hiding this comment.
Did you test with a package that was in the middle of scanning? What are the values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16 and #43