Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.5 breaks barcode scanning #1584

Closed
freelock opened this issue May 21, 2016 · 2 comments · Fixed by #7339
Closed

1.5 breaks barcode scanning #1584

freelock opened this issue May 21, 2016 · 2 comments · Fixed by #7339
Assignees
@ehuelsmann
Labels
new-ui To be realized in the new Vue Ui type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0)

Comments

@freelock
Copy link
Member

In previous versions, you could enter multiple items in a row with simply the sku and keys. I know this was done to support bar-code readers, which act as a keyboard entering the string in the barcode followed by enter.

Before, when you enter a sku and press Enter, the form refreshed with the line item added, and the cursor focused on the SKU field of the next (new) line item).

Now when you do this, the parts selector does not fire. The sku and line item is added and set to read-only, with no other fields filled in, and no new line item created for the next part.
@einhverfr einhverfr modified the milestone: 1.5 May 26, 2016
@ehuelsmann ehuelsmann added the type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0) label Jun 5, 2016
@einhverfr einhverfr removed this from the 1.5 milestone Jul 2, 2017
@einhverfr einhverfr reopened this Jul 2, 2017
@ehuelsmann ehuelsmann added the new-ui To be realized in the new Vue Ui label May 9, 2022
ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Jan 8, 2023
@ehuelsmann
Restore focussing behaviour on AR/AP and Orders/Quotes
426ba04 
When we switched to being a Single Page Application (SPA) on the client
in version 1.5, we lost how the next data entry row was selected on
page refresh. This comit restores that for invoices, orders, quotes and
AR/AP transactions (but not GL transactions).

Re ledgersmb#1584
@ehuelsmann ehuelsmann mentioned this issue Jan 8, 2023
Merged
@ehuelsmann
Copy link
Member

#7070 fixes the data being filled in and the move to the next data entry row. It does not fix the barcode lookup.

ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Jan 8, 2023
@ehuelsmann
Restore focussing behaviour on AR/AP and Orders/Quotes
0fc2c02 
When we switched to being a Single Page Application (SPA) on the client
in version 1.5, we lost how the next data entry row was selected on
page refresh. This comit restores that for invoices, orders, quotes and
AR/AP transactions (but not GL transactions).

Re ledgersmb#1584
@ehuelsmann ehuelsmann mentioned this issue Jan 8, 2023
Merged
@ehuelsmann ehuelsmann changed the title 1.5 Regression on keyboard entry of multiple items by sku - breaks barcode scanning 1.5 Regression breaks barcode scanning Jan 8, 2023
@ehuelsmann
Copy link
Member

Changing topic of the issue to indicate that the only remaining issue here - if anything - is that the barcode being scanned isn't being matched.

@ehuelsmann ehuelsmann mentioned this issue Jan 26, 2023
Closed
@ehuelsmann ehuelsmann self-assigned this Jan 26, 2023
@ehuelsmann ehuelsmann changed the title 1.5 Regression breaks barcode scanning 1.5 breaks barcode scanning Jan 29, 2023
ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Apr 15, 2023
@ehuelsmann
Add barcode scanner support (back) to invoices
f92ce1e 
Fixes ledgersmb#1584
@ehuelsmann ehuelsmann mentioned this issue Apr 15, 2023
Merged
ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Apr 17, 2023
@ehuelsmann
Add barcode scanner support (back) to orders
2b072a5 
Re ledgersmb#1584
@ehuelsmann ehuelsmann mentioned this issue Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehuelsmann ehuelsmann

Labels
new-ui To be realized in the new Vue Ui type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add barcode scanner support (back) to invoices ehuelsmann/LedgerSMB
3 participants
@freelock @einhverfr @ehuelsmann