Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bv_normalize loose mvars #5918

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: bv_normalize loose mvars #5918

merged 1 commit into from
Nov 1, 2024

Conversation

hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Nov 1, 2024

bv_normalize would just silently drop other goals if called while not focused on a singular goal, for example:

theorem mvarid (x y : Bool) (h : x ∨ y) : y ∨ x := by
  cases h
  bv_normalize
  -- we want to write another bv_normalize here but all goals are gone

Would make the second subgoal disappear and then throw an error about meta variables in the kernel.

@hargoniX hargoniX enabled auto-merge November 1, 2024 14:58
@tobiasgrosser
Copy link
Contributor

Thank you.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 1, 2024 15:07 Inactive
@hargoniX hargoniX added this pull request to the merge queue Nov 1, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 1, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase fd08c9206097781c9bca8f61531de6a0479df0f8 --onto 0fcee100e7ea382069854d91e854265c56b54428. (2024-11-01 15:19:50)

Merged via the queue into master with commit a4057d3 Nov 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants