Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: attribute [simp ←] #5870

Merged
merged 12 commits into from
Oct 29, 2024
Merged

feat: attribute [simp ←] #5870

merged 12 commits into from
Oct 29, 2024

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Oct 28, 2024

This adds the ability to add the converse direction of a rewrite rule not just in simp arguments simp [← thm], but also as a global attribute

attribute [simp ←] thm

This fixes #5828.

This can be undone with attribute [-simp], although note that [-simp] wins and cannot be undone at the moment (#5868).

Like simp [← thm] (see #4290), this will do an implicit attribute [-simp] thm if the other direction is already defined.

@github-actions github-actions bot added the changes-stage0 Contains stage0 changes, merge manually using rebase label Oct 28, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 28, 2024 16:53 Inactive
@github-actions github-actions bot added toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN and removed changes-stage0 Contains stage0 changes, merge manually using rebase labels Oct 28, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 28, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5870
a6b4e36
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 28, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5870
53ea606
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 28, 2024 17:13 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 28, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5870
4a948b2
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 28, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5870
a39f29e
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 28, 2024 •
edited
Loading

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 28, 2024
nomeata added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 29, 2024
@nomeata
refactor: avoid passing both directions of a lemma to simp
0b01e55 
this only works by chance, in a way, and will break when
leanprover/lean4#5870 lands
@nomeata nomeata mentioned this pull request Oct 29, 2024
Closed
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Oct 29, 2024
@nomeata nomeata marked this pull request as ready for review October 29, 2024 10:28
@nomeata nomeata requested a review from leodemoura as a code owner October 29, 2024 10:28
@nomeata nomeata enabled auto-merge October 29, 2024 10:39
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Oct 29, 2024
@nomeata
refactor: avoid passing both directions of a lemma to simp (#18373)
c9027b3 
this only works by chance, in a way, and will break when
leanprover/lean4#5870 lands
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5870
94ae909
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 29, 2024 11:04 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5870
396b469
@nomeata nomeata added this pull request to the merge queue Oct 29, 2024
Merged via the queue into master with commit 6514385 Oct 29, 2024
15 checks passed
@nomeata nomeata deleted the joachim/simp-attrib-modifiers branch October 29, 2024 11:34
jcommelin pushed a commit to leanprover-community/mathlib4 that referenced this pull request Oct 29, 2024
@nomeata @jcommelin
refactor: avoid passing both directions of a lemma to simp (#18373)
287e08b 
this only works by chance, in a way, and will break when
leanprover/lean4#5870 lands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: simp attribute to accept ← modifier
2 participants
@nomeata @leanprover-community-bot