-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: instantiateMVars
slowdown in the language server
#5805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kha
force-pushed
the
push-xnktosuuutww
branch
from
October 22, 2024 11:23
1461116
to
bc32de2
Compare
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Oct 22, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 22, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 22, 2024
leanprover-community-bot
added
the
builds-mathlib
CI has verified that Mathlib builds against this PR
label
Oct 22, 2024
Mathlib CI status (docs):
|
Kha
force-pushed
the
push-xnktosuuutww
branch
from
October 24, 2024 08:27
bc32de2
to
c1165e7
Compare
Kha
force-pushed
the
push-xnktosuuutww
branch
from
October 24, 2024 08:28
c1165e7
to
b8a5c2d
Compare
!bench |
Here are the benchmark results for commit b8a5c2d. Benchmark Metric Change
=============================================================
+ big_omega.lean MT branch-misses -35.6% (-76.8 σ)
+ big_omega.lean MT branches -29.5% (-2209.9 σ)
+ big_omega.lean MT instructions -29.8% (-3617.5 σ)
+ big_omega.lean MT task-clock -48.8% (-14.1 σ)
+ big_omega.lean MT wall-clock -48.8% (-14.1 σ)
+ parser task-clock -2.7% (-11.9 σ)
+ parser wall-clock -2.7% (-11.8 σ)
+ stdlib instantiate metavars -14.3% (-112.8 σ)
- stdlib share common exprs 2.2% (11.5 σ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5614