Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instantiateMVars slowdown in the language server #5805

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Oct 22, 2024

Fixes #5614

@Kha Kha requested a review from leodemoura as a code owner October 22, 2024 11:14
@Kha Kha force-pushed the push-xnktosuuutww branch from 1461116 to bc32de2 Compare October 22, 2024 11:23
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 22, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 22, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 22, 2024
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 22, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 22, 2024

Mathlib CI status (docs):

  • ✅ Mathlib branch lean-pr-testing-5805 has successfully built against this PR. (2024-10-22 12:36:57) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9157c1f2792ddcf792b2b212185a2449078356b5 --onto 66dbad911eaaec4cd512662bd5cc67a2a16d2484. (2024-10-24 08:49:08)

@Kha Kha force-pushed the push-xnktosuuutww branch from bc32de2 to c1165e7 Compare October 24, 2024 08:27
@Kha Kha force-pushed the push-xnktosuuutww branch from c1165e7 to b8a5c2d Compare October 24, 2024 08:28
@Kha
Copy link
Member Author

Kha commented Oct 24, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit b8a5c2d.
There were significant changes against commit 9157c1f:

  Benchmark           Metric                 Change
  =============================================================
+ big_omega.lean MT   branch-misses          -35.6%   (-76.8 σ)
+ big_omega.lean MT   branches               -29.5% (-2209.9 σ)
+ big_omega.lean MT   instructions           -29.8% (-3617.5 σ)
+ big_omega.lean MT   task-clock             -48.8%   (-14.1 σ)
+ big_omega.lean MT   wall-clock             -48.8%   (-14.1 σ)
+ parser              task-clock              -2.7%   (-11.9 σ)
+ parser              wall-clock              -2.7%   (-11.8 σ)
+ stdlib              instantiate metavars   -14.3%  (-112.8 σ)
- stdlib              share common exprs       2.2%    (11.5 σ)

@Kha Kha added this pull request to the merge queue Oct 25, 2024
Merged via the queue into leanprover:master with commit 748f0d6 Oct 25, 2024
13 checks passed
@Kha Kha deleted the push-xnktosuuutww branch October 25, 2024 11:11
@Kha Kha restored the push-xnktosuuutww branch October 27, 2024 12:25
@Kha Kha deleted the push-xnktosuuutww branch October 27, 2024 12:26
tobiasgrosser pushed a commit to opencompl/lean4 that referenced this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instantiate metavars takes enormously long in VSCode, but is snappy in the terminal
3 participants