Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable ac_nf by default #5673

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Oct 10, 2024

We trust that the users read the error messages or tactic docs to discover the option.
AWS problems have shown that this can be too eager of an operation to do.
Given that we have the luxury of interactivity let's go for an approach where the users
can optionally enable it.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 10, 2024 21:15 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 10, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 10, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 96e996e16d0c8f8c10f9112ab180943e6113f710 --onto d10d41bc07942ca6d8f3081a637045321db15c5a. (2024-10-10 21:29:40)
  • ✅ Mathlib branch lean-pr-testing-5673 has successfully built against this PR. (2024-10-14 22:28:11) View Log

@hargoniX hargoniX force-pushed the hbv/bv_decide_ac_nf_disable branch from cc92af7 to 2b045a9 Compare October 14, 2024 21:05
@hargoniX hargoniX marked this pull request as ready for review October 14, 2024 21:05
@hargoniX hargoniX force-pushed the hbv/bv_decide_ac_nf_disable branch from 2b045a9 to 6543f7c Compare October 14, 2024 21:07
@hargoniX hargoniX enabled auto-merge October 14, 2024 21:07
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 14, 2024 21:20 Inactive
@hargoniX hargoniX added this pull request to the merge queue Oct 14, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 14, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 14, 2024
Merged via the queue into master with commit adfbc56 Oct 14, 2024
16 checks passed
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants