Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upstream and update #where command #5065

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Aug 16, 2024

This command comes from Lean 3, which I had previously ported and contributed to Batteries (née Std). In this new version, #where produces actual command Syntax for all features of a top-level scope (rather than splicing together strings), and it also now reports included variables.

This command comes from Lean 3, which I had previously ported and contributed to Batteries (née Std). In this new version, `#where` produces actual command Syntax for all features of a top-level scope (rather than splicing together strings), and it also now reports included variables.
@kmill kmill requested a review from Kha as a code owner August 16, 2024 00:49
@kmill
Copy link
Collaborator Author

kmill commented Aug 16, 2024

@semorrison Here's an upstreamed #where!

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 16, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 16, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 16, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 16, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Aug 16, 2024

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 16, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 16, 2024
@kim-em kim-em enabled auto-merge October 25, 2024 01:27
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 25, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 8822b0fca7f0b232742e7ee1aea92067e4340952 --onto 09e1a05ee922bf8581ba9820f096ac1a2b1a2945. (2024-10-25 01:49:37)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 8822b0fca7f0b232742e7ee1aea92067e4340952 --onto 4ee44ceb1d77f16b9b81bc655bc8b318cd6e8c4d. (2024-10-30 02:16:41)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 8822b0fca7f0b232742e7ee1aea92067e4340952 --onto 38c39482f40536b864a9b43c718e10e8413b26e5. (2024-10-30 18:01:31)

@kim-em kim-em added this pull request to the merge queue Oct 30, 2024
Merged via the queue into leanprover:master with commit c3cbc92 Oct 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants