-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require minimum key size for OpenSSL keys #855
Conversation
Thanks @Slamdunk! I'll review it ASAP (I've been dealing with so many things at work this week 😰) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, I'll rebase your branch to handle them and we can get it merged.
Thanks for your help!
b2f996e
to
a7bb8dd
Compare
a7bb8dd
to
82ad9ce
Compare
I think we're good for 4.2.0 🎉 @Slamdunk thanks for all your help! |
Fixes #854
Few notes to read the PR effectively:
Hmac::minimumBytesLengthForKey
has been renamed toHmac::minimumBitsLengthForKey
but it's not a BC-Break since it hasn't been released yetUnsafe*
classes behave like the previous one and have already been marked as@deprecated
openssl_sign
error test::signShouldRaiseAnExceptionWhenKeyIsInvalid
used a short key to testsCannotSignPayload
exception raise, but now that's blocked earlier and onlyUnsafeRsaTest
covers those lines of code. In the next major I guess we'll need to just replace theif (! openssl_sign
with an assert, maybe?MT fails because I've been a bit too wary:
Honestly I don't have enough trust in PHP to delete this.