Be more clear about adding validation constraints in the doc #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies @NicolasCARPi, for some weird reason I missed the notifications on this PR. |
lcobucci
approved these changes
Nov 15, 2021
|
@NicolasCARPi it seems like you removed access to maintainers on your fork while creating the PR and I can't rebase it. |
|
@lcobucci I don't think I unticked that checkbox, but who knows! I've updated the branch. |
|
Thanks! |
|
Too bad that this has been removed from docs here: fb752da#diff-2a5cc5840033df051eb77a74837870ef13bd74dd8279f0270c498591728bce00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #767
For me, this is what I think was missing and made me wonder "ok but how do I add a constraint??".
So I added a comment in the code to point to the configuration doc and more importantly an example code after listing the available validationconstraints, at it makes sense to show how to actually use them after listing them.
Cheers,
~Nico