Fix deprecation notes #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the exact same interface as v4.0 to sign tokens. An interesting side-effect is that signatures are just created when instantiating the token, which is the moment that's actually needed.
We don't have the correct methods yet so it's not really helpful to have these here. We should add them back on v3.4 when features from v4.x get backported.
They're not helpful as well since functionality hasn't been ported from v4.0. We'll add them back on v3.4.
Adding references to which methods should be used instead
|
@MasterOdin can you please let me know if this solves the issue you raised? I don't want for this lib to annoy people with useless deprecation notes. |
|
Yeah, this looks like it would solve my issue in that there's a way to use non-deprecated functions for generating a token! 👍 One thing I noticed while looking through this is that the 3.3 release uses Builder::with while 4.0 uses Builder::withClaim. |
|
@MasterOdin well spotted! I'll fix it too. Thanks! |
|
@MasterOdin released 👍 |
|
Thanks so much! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @MasterOdin in #133 we were a bit too eager to add the deprecation notes.
This solves that, allowing users to migrate in a smooth way.