feat(configFactory): be able to access junit-context during config of the server #17
Conversation
|
yea, looks good, thx for the PR, please continue |
|
If this is ok for you, could you say to me what you would like me to add to this PR to be accepted? |
davinkevin
force-pushed
the
9-create-with-extension-context
branch
from
253f708 to
bc740c5
Compare
|
I've added one unit test about this new feature. If this is enough from your point of view, you can merge it 👍 |
| @@ -14,9 +15,9 @@ | |||
| */ | |||
| class WiremockFactory { | |||
|
|
|||
| public WireMockServer createServer(final Wiremock mockedServer) { | |||
| public WireMockServer createServer(final Wiremock mockedServer, ExtensionContext extensionContext) { | |||
There was a problem hiding this comment.
can I ask you to keep the previous signature as well? To not break the binary compatibility. Thus you can avoid changes on the tests, adding nulls where the context should be
There was a problem hiding this comment.
Ok, and I've extracted the instantiation of the factory inside a private method.
BTW, the method newInstance() is deprecated since Java 9:
Is it ok for you?
There was a problem hiding this comment.
yeah, j8 is the main target for now still, but thx for pointing
|
please rebase on master, fixed an issue with the build |
davinkevin
force-pushed
the
9-create-with-extension-context
branch
from
bc740c5 to
42c1796
Compare
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
============================================
+ Coverage 93.75% 94.02% +0.27%
- Complexity 24 28 +4
============================================
Files 7 7
Lines 64 67 +3
Branches 2 2
============================================
+ Hits 60 63 +3
Misses 1 1
Partials 3 3
Continue to review full report at Codecov.
|
… the server Closes lanwen#9
davinkevin
force-pushed
the
9-create-with-extension-context
branch
from
42c1796 to
d5f8095
Compare
|
Rebase done on master, I let you decide if all is ok for you. I will try to work on #16 if possible 😉 |
|
great, thank you, will release that shortly |
Closes #9