Fibonacci Stark Prover #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
reviewed
Feb 14, 2023
mpaulucci
reviewed
Feb 14, 2023
pablodeymo
force-pushed
the
fri-operation
branch
from
af9656e to
d8154c4
Compare
pablodeymo
force-pushed
the
fri-operation
branch
from
d63140e to
f15af6b
Compare
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 95.79% 95.63% -0.16%
==========================================
Files 45 49 +4
Lines 4680 5155 +475
==========================================
+ Hits 4483 4930 +447
- Misses 197 225 +28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jrchatruc
approved these changes
Mar 2, 2023
ilitteri
reviewed
Mar 2, 2023
| @@ -151,6 +151,11 @@ where | |||
| fn from_base_type(x: Self::BaseType) -> Self::BaseType { | |||
| MontgomeryAlgorithms::cios(&x, &C::R2, &C::MODULUS, &C::MU) | |||
| } | |||
|
|
|||
| // TO DO: Add tests for representatives | |||
There was a problem hiding this comment.
Let's make an issue to track this TODO
There was a problem hiding this comment.
We could label it as "good first issue".
There was a problem hiding this comment.
Sounds good, created it here #138
ilitteri
reviewed
Mar 2, 2023
| @@ -127,6 +127,10 @@ where | |||
| fn from_base_type(x: [FieldElement<Q::BaseField>; 3]) -> [FieldElement<Q::BaseField>; 3] { | |||
| x | |||
| } | |||
|
|
|||
| fn representative(_x: Self::BaseType) -> Self::BaseType { | |||
| todo!() | |||
ilitteri
reviewed
Mar 2, 2023
| @@ -105,6 +105,10 @@ where | |||
| fn from_base_type(x: [FieldElement<Q::BaseField>; 2]) -> [FieldElement<Q::BaseField>; 2] { | |||
| x | |||
| } | |||
|
|
|||
| fn representative(_x: Self::BaseType) -> Self::BaseType { | |||
| todo!() | |||
jrchatruc
approved these changes
Mar 2, 2023
entropidelic
approved these changes
Mar 2, 2023
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation of the stark proving system for the fibonacci sequence. There are a lot of
TODOs left, which we'll tackle in other PRs, like adding fiat-shamir, zerofiers, etc.A few things were added out of need:
representative()method forFieldElements, which returns the field element's value in plain form (if the felt is in montgomery form, this returns the actual value the user expects, not its montgomery representation).composefunction to compute the composition of two polynomials.