feat(hints): add NewHint#28 #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
Oppen
reviewed
Apr 14, 2023
src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #989 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 75 75
Lines 31142 31155 +13
=======================================
+ Hits 30446 30459 +13
Misses 696 696
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Apr 14, 2023
pefontana
added
the
whitelisted-hint
fmoletta
approved these changes
Apr 14, 2023
Oppen
approved these changes
Apr 14, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add `COMPUTE_SLOPE_WHITELIST` hint * Update changelog * Fix: add missing return to cairo program * Add `EC_DOUBLE_SCOPE_WHITELIST` hint * Update changelog * Add NewHint#28 * Update changelog * Use name without WHITELIST * Remove comments and add source * Readd deleted comments * Change assert_matches for assert + is_ok --------- Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends: #986
This PR adds the missing hint NewHint#28, now known as
VERIFY_ZERO_V2. Also renameVERIFY_ZEROtoVERIFY_ZERO_V1