Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose compute effective sizes from the vm #887

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Mar 9, 2023

Expose compute effective sizes from the vm

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

src/vm/vm_core.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm fren

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #887 (dee5332) into main (c326ba8) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

❗ Current head dee5332 differs from pull request most recent head 7b130d5. Consider uploading reports for the commit 7b130d5 to get more accurate results

@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   97.42%   97.41%   -0.01%     
==========================================
  Files          69       69              
  Lines       29120    29141      +21     
==========================================
+ Hits        28369    28387      +18     
- Misses        751      754       +3     
Impacted Files Coverage Δ
src/vm/vm_core.rs 97.40% <85.71%> (-0.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jrigada Jrigada merged commit 17f467c into main Mar 9, 2023
@Jrigada Jrigada deleted the expose-compute-effective-sizes branch March 9, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants