Feature: add a method to retrieve the output builtin from the VM #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
odesenfans
force-pushed
the
msl/vm-get-output-builtin-runner
branch
from
cff7a5c to
a1113d7
Compare
juanbono
reviewed
Mar 27, 2024
Oppen
reviewed
Mar 27, 2024
juanbono
approved these changes
Mar 27, 2024
fmoletta
reviewed
Apr 3, 2024
Problem: the output builtin often needs to be manipulated directly in the Starknet bootloader and OS hints. Solution: add a `get_output_builtin() method on the `VirtualMachine` struct to retrieve a reference to the output builtin easily.
odesenfans
force-pushed
the
msl/vm-get-output-builtin-runner
branch
from
13d5749 to
afa0879
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
==========================================
- Coverage 96.56% 96.56% -0.01%
==========================================
Files 95 95
Lines 38380 38407 +27
==========================================
+ Hits 37062 37088 +26
- Misses 1318 1319 +1 ☔ View full report in Codecov by Sentry. |
fmoletta
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the output builtin often needs to be manipulated directly in the Starknet bootloader and OS hints.
Solution: add a
get_output_builtin() method on theVirtualMachine` struct to retrieve a reference to the output builtin easily.Description of the pull request changes and motivation.
Checklist