-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Performance benchmark #46
Conversation
Pull Request Test Coverage Report for Build 3384873998Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I added a couple of minor comments.
Probe |
@nmate @levaitamas Could you give another review? |
@davidkornel thanks for addressing the comments, and the figures are great! I still have some ideas/comments. Do you mind if I do some edits on your code/branch? |
I don't mind at all, if I can learn new stuff that's always good. Go ahead. Curious to see your ideas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise I like it!
An example script to evaluate the performance of STUNner in and outside of Kubernetes.