Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Performance benchmark #46

Merged
merged 23 commits into from
Nov 4, 2022
Merged

test: Performance benchmark #46

merged 23 commits into from
Nov 4, 2022

Conversation

davidkornel
Copy link
Member

An example script to evaluate the performance of STUNner in and outside of Kubernetes.

@davidkornel davidkornel requested review from rg0now and nmate October 27, 2022 17:02
@coveralls
Copy link

coveralls commented Oct 27, 2022

Pull Request Test Coverage Report for Build 3384873998

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 59 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 67.535%

Files with Coverage Reduction New Missed Lines %
stunner.go 3 83.82%
turncat.go 56 55.56%
Totals Coverage Status
Change from base Build 3328077813: 0.3%
Covered Lines: 726
Relevant Lines: 1075

💛 - Coveralls

Copy link
Member

@levaitamas levaitamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I added a couple of minor comments.

examples/benchmark/README.md Outdated Show resolved Hide resolved
examples/benchmark/README.md Outdated Show resolved Hide resolved
examples/benchmark/README.md Outdated Show resolved Hide resolved
examples/benchmark/README.md Outdated Show resolved Hide resolved
examples/benchmark/README.md Outdated Show resolved Hide resolved
examples/benchmark/benchmark.sh Show resolved Hide resolved
examples/benchmark/README.md Outdated Show resolved Hide resolved
examples/benchmark/benchmark.sh Show resolved Hide resolved
examples/benchmark/iperf-server.yaml Outdated Show resolved Hide resolved
examples/benchmark/README.md Show resolved Hide resolved
@nmate
Copy link
Contributor

nmate commented Oct 28, 2022

Probe

examples/benchmark/README.md Outdated Show resolved Hide resolved
examples/benchmark/README.md Outdated Show resolved Hide resolved
examples/benchmark/README.md Outdated Show resolved Hide resolved
@davidkornel
Copy link
Member Author

@nmate @levaitamas Could you give another review?

@levaitamas
Copy link
Member

@davidkornel thanks for addressing the comments, and the figures are great! I still have some ideas/comments. Do you mind if I do some edits on your code/branch?

@davidkornel
Copy link
Member Author

@davidkornel thanks for addressing the comments, and the figures are great! I still have some ideas/comments. Do you mind if I do some edits on your code/branch?

I don't mind at all, if I can learn new stuff that's always good. Go ahead. Curious to see your ideas.

Copy link
Contributor

@nmate nmate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise I like it!

examples/benchmark/README.md Outdated Show resolved Hide resolved
examples/benchmark/README.md Show resolved Hide resolved
examples/benchmark/README.md Outdated Show resolved Hide resolved
examples/benchmark/benchmark.sh Show resolved Hide resolved
examples/benchmark/benchmark.sh Show resolved Hide resolved
examples/benchmark/benchmark.sh Show resolved Hide resolved
@davidkornel davidkornel changed the title feature: Performance benchmark test: Performance benchmark Nov 4, 2022
@davidkornel davidkornel merged commit f0d8100 into main Nov 4, 2022
@levaitamas levaitamas deleted the performance_evaluations branch November 10, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants