Allow user to specify FUNCHOOK_CPU explicitly #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently funchook attempts to determine FUNCHOOK_CPU using CMAKE_SYSTEM_PROCESSOR. This isn't particularly robust especially when you start working with various toolchains. CMAKE_SYSTEM_PROCESSOR doesn't seem to have a definitive list of accepted values i.e. for aarch64 I've seen aarch64/arm64/armv8/armv8_64. Allowing the user of funchook to explicitly set FUNCHOOK_CPU seems like a safer option for some users. The alternative for an external user is to push/pop setting CMAKE_SYSTEM_PROCESSOR which isn't very nice.
|
Thanks. It seems reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently funchook attempts to determine FUNCHOOK_CPU using CMAKE_SYSTEM_PROCESSOR. This isn't particularly robust especially when you start working with various toolchains. CMAKE_SYSTEM_PROCESSOR doesn't seem to have a definitive list of accepted values i.e. for aarch64 I've seen aarch64/arm64/armv8/armv8_64.
Allowing the user of funchook to explicitly set FUNCHOOK_CPU seems like a safer option for some users. The alternative for an external user is to push/pop setting CMAKE_SYSTEM_PROCESSOR which isn't very nice.