-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix inverted logic for resource logic #6700
Conversation
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Error: running mkcmp: exit status 1 |
All Times Minikube (PR 6700): [ 92.618670 92.048396 93.256389] Average minikube: 93.174073 Averages Time Per Log
|
All Times minikube: [ 97.838731 94.397550 91.841780] Average minikube: 94.692687 Averages Time Per Log
|
medmac@~/minikube (mount_kic) $ ./out/minikube start --vm-driver=docker -p p2 --memory=2500mb
⚠️ The 'docker' driver does not respect the --memory flag
😄 [p2] minikube v1.7.2 on Darwin 10.13.6
✨ Using the docker (experimental) driver based on user configuration
also the lint issue on master, which travis didnt show on the PR