Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipv6 dual stack (Phase 1 - ALPHA) #73977

Merged
merged 10 commits into from
Jul 3, 2019
Merged

ipv6 dual stack (Phase 1 - ALPHA) #73977

merged 10 commits into from
Jul 3, 2019

Conversation

khenidak
Copy link
Contributor

@khenidak khenidak commented Feb 12, 2019 •
edited
Loading

What type of PR is this?
/kind api-change

/kind feature

Implements: kubernetes/enhancements#808
Included:

  • Types modification.
  • Conversions.
  • new conversion unit tests.
  • (updated existing unit tests to match the type changes).
  • node ipam controller that supports multi cidrs.
  • unit tests: node ipam mutli cidr.
  • azure cloud provider support for mutli routes per node.
  • unit tests: azure cloud provider support for mutli routes per node.
  • kubenet support for dual-stack.
  • revise host networking for dual-stack (v1.16).
  • unit tests: kubenet support for dual-stack.
  • e2e tests (as a stand alone PR referenced below).
To configure controller manager to use ipv6dual stack:
use --cluster-cidr="<cidr1>,<cidr2>".

Notes:
 
1. Only the first two cidrs are used (soft limits for Alpha, might be lifted later on). 
2. Only the "RangeAllocator" (default) is allowed as a value for --cidr-allocator-type . Cloud allocators are not compatible with ipv6dualstack

CC @lachie83 @thockin

What is in the box? (alpha status)

  • Node ipam controller now supports multi-cidr per node (node.Spec.PodCIDRs).
  • Pod.PodStatus.PodIPs supports multiple IPs.
  • Route Controller now supports creating routes per node's cidr.
  • kubenet now supports dualstack.
  • Azure support Route() interface implementation for dualstack.
  • Known issue: kubenet will always force reporting ipv4, ipv6 (irrespective of podCIDRs order).
  • updates to CRI to support reporting multiple IPs per PodSandBox.

Known Issues

  • Cluster ipv6 CIDRS mask bigger than 24 will fail
  • ipv6 cidr assignment is using the default ipv4 cidr /24 (Future: add controls over v6 cidr size)
  • kubenet forces v4,v6 reporting of IPs, users who mustv6,v4 as --cluster-cidr
  • Masquerading is not done by kubenet. Users will have to use ip-masq-agent to perform masquerading correctly for ipv6. A standing PR has been created to support this feature Support for IPv6 kubernetes-sigs/ip-masq-agent#45

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 12, 2019
@lachie83 lachie83 mentioned this pull request Feb 12, 2019
Merged
@khenidak khenidak mentioned this pull request Feb 15, 2019
Closed
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 6, 2019
@chrisohaver
Copy link
Contributor

@chrisohaver

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels May 9, 2019
@dims
Copy link
Member

dims commented Jul 2, 2019

/test pull-kubernetes-local-e2e

@thockin
Copy link
Member

thockin commented Jul 2, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2019
@thockin thockin added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dcbw, feiskyer, khenidak, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dcbw, feiskyer, khenidak, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a33840e into kubernetes:master Jul 3, 2019
tedyu
tedyu reviewed Jul 3, 2019
View reviewed changes
cmd/cloud-controller-manager/app/core.go
return nil, false, fmt.Errorf("len of ClusterCIDRs==%v and they are not configured as dual stack (at least one from each IPFamily", len(clusterCIDRs))
}

// failure: more than cidrs is not allowed even with dual stack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more than cidrs is -> more than two cidrs are

cmd/kube-controller-manager/app/core.go
return nil, false, err
}

// failure: more than one cidr and dual stack is not enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the following code is almost the same as the check in core.go

Consider consolidating the code into a helper.

@khenidak khenidak mentioned this pull request Jul 3, 2019
Merged
@Arvinderpal Arvinderpal mentioned this pull request Jul 8, 2019
Closed
@aramase aramase mentioned this pull request Jul 10, 2019
Merged
2 tasks
@andrewsykim andrewsykim mentioned this pull request Jul 12, 2019
Closed
@saschagrunert
Copy link
Member

saschagrunert commented Jul 15, 2019 •
edited
Loading

@khenidak Do you think that we can change the release notes for this PR?

It would be awesome if we could state all user-facing changes within the release-notes block, like the dual stack support of kubenet. We can also add an additional docs block now, where we could link the related KEP.

@saiyan86 saiyan86 mentioned this pull request Jul 16, 2019
Closed
@khenidak
Copy link
Contributor Author

@saschagrunert sure. Do you have a template i can follow?

@saschagrunert
Copy link
Member

@saschagrunert sure. Do you have a template i can follow?

Thanks, the only template we have is in the pull request template:https://raw.githubusercontent.com/kubernetes/kubernetes/master/.github/PULL_REQUEST_TEMPLATE.md

So it would be nice if we can add the documentation (KEP) as well.

@Arvinderpal Arvinderpal mentioned this pull request Aug 3, 2019
Merged
1 task
@uablrek uablrek mentioned this pull request Aug 5, 2019
Closed
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
@kcmartin
Copy link

@khenidak Hi! I'm following up for sig-release re: @saschagrunert 's above request:

#73977 (comment)

Where do we stand on getting a release note with user-facing changes?
Thanks!

@lachie83 lachie83 mentioned this pull request Aug 22, 2019
Merged
@varunmar varunmar mentioned this pull request Sep 6, 2019
Closed
@neolit123 neolit123 mentioned this pull request Nov 21, 2019
Merged
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#73977 from khenidak/ipv6dualstack
87b980a 
ipv6 dual stack (Phase 1 - ALPHA)

Kubernetes-commit: a33840e
@liggitt liggitt mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vllry vllry vllry left review comments

@tedyu tedyu tedyu left review comments

@aojea aojea aojea left review comments

@Arvinderpal Arvinderpal Arvinderpal left review comments

@bjhaid bjhaid bjhaid left review comments

@feiskyer feiskyer feiskyer left review comments

@saschagrunert saschagrunert saschagrunert left review comments

@liggitt liggitt liggitt left review comments

@uablrek uablrek uablrek left review comments

@justinsb justinsb justinsb left review comments

@squeed squeed squeed left review comments

@aramase aramase aramase left review comments

@dims dims dims left review comments

@dcbw dcbw dcbw left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@MikeSpreitzer MikeSpreitzer MikeSpreitzer requested changes

@jrroman jrroman jrroman left review comments

@thockin thockin thockin approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@erictune erictune Awaiting requested review from erictune

Assignees

@mauilion mauilion

@thockin thockin

@vllry vllry

@dcbw dcbw

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.