fix race condition when attach azure disk in vmss #71992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
sig/cloud-provider
|
/retest |
fix gofmt issue
andyzhangx
force-pushed
the
vmss-update-issue
branch
from
e5a97ae to
c12e82f
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Dec 21, 2018
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 27, 2018
…1992-upstream-release-1.12 Automated cherry pick of #71992: fix race condition when attach azure disk in vmss
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 4, 2019
…1992-upstream-release-1.11 Automated cherry pick of #71992: fix race condition when attach azure disk in vmss
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 5, 2019
…1992-upstream-release-1.13 Automated cherry pick of #71992: fix race condition when attach azure disk in vmss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
When attach/detach azure disk in vmss, it updates whole VM info, including:
networkProfile,storageProfile, while this would lead to race condition when there is also network related setting changing in k8s cloud provider in the mean time.This PR fixed this issue by using a new vm data and only updates
storageProfilerelated info.Related RESET api doc could be found here:
https://docs.microsoft.com/en-us/rest/api/compute/virtualmachinescalesetvms/update
Which issue(s) this PR fixes:
Fixes #71991
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Release note:
/kind bug
/assign @feiskyer
/priority important-soon
/sig azure
cc @brendandburns @khenidak
By my testing, it works well in disk attach/detach, while let me hold for a while, check with vmss team first. Thanks.
/hold