Correctly Clear conntrack entry on endpoint changes when using nodeport #71573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
|
Hi @JacobTanenbaum. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
sig/network
JacobTanenbaum
force-pushed
the
UDP_conntrack
branch
from
40d5889 to
cf3d07b
Compare
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
squeed
reviewed
Nov 30, 2018
pkg/util/conntrack/conntrack.go
Outdated
| @@ -107,3 +107,19 @@ func ClearEntriesForNAT(execer exec.Interface, origin, dest string, protocol v1. | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| // ClearEntriesForNATPort uses the conntrack tool to delete the contrack entries | |||
There was a problem hiding this comment.
nit: docblock function name mismatch
|
/retest |
When using NodePort to connect to an endpoint using UDP, if the endpoint is deleted on restoration of the endpoint traffic does not flow. This happens because conntrack holds the state of the connection and the proxy does not correctly clear the conntrack entry for the stale endpoint. Introduced a new function to conntrack ClearEntriesForPortNAT that uses the endpointIP and NodePort to remove the stale conntrack entry and allow traffic to resume when the endpoint is restored. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
JacobTanenbaum
force-pushed
the
UDP_conntrack
branch
from
cf3d07b to
144280e
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest |
knobunc
approved these changes
Dec 4, 2018
|
@JacobTanenbaum can you add the release note to the PR description per #71573 (comment) ? |
k8s-ci-robot
added
the
lgtm
|
/milestone v1.14 |
|
@smarterclayton can you take a quick look at this one? |
k8s-ci-robot
added
release-note
JacobTanenbaum
changed the title
|
@bowei any thoughts on this one? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JacobTanenbaum, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Dec 13, 2018
ravens
added a commit
to ravens/kubernetes
that referenced
this pull request
Nov 5, 2020
A previous PR (kubernetes#71573) intended to clear conntrack entry on endpoint changes when using nodeport by introducing a dedicated function to remove the stale conntrack entry on the node port and allow traffic to resume. By doing so, it has introduced a nodeport specific bug where the conntrack entries related to the ClusterIP does not get clean if endpoint is changed (issue kubernetes#96174). We fix by doing ClusterIP cleanup in all cases.
jingxu97
pushed a commit
to jingxu97/kubernetes
that referenced
this pull request
Nov 7, 2020
A previous PR (kubernetes#71573) intended to clear conntrack entry on endpoint changes when using nodeport by introducing a dedicated function to remove the stale conntrack entry on the node port and allow traffic to resume. By doing so, it has introduced a nodeport specific bug where the conntrack entries related to the ClusterIP does not get clean if endpoint is changed (issue kubernetes#96174). We fix by doing ClusterIP cleanup in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using NodePort to connect to an endpoint using UDP, if the endpoint is deleted on
restoration of the endpoint traffic does not flow. This happens because conntrack holds
the state of the connection and the proxy does not correctly clear the conntrack entry
for the stale endpoint.
Introduced a new function to conntrack ClearEntriesForPortNAT that uses the endpointIP
and NodePort to remove the stale conntrack entry and allow traffic to resume when
the endpoint is restored.
Signed-off-by: Jacob Tanenbaum jtanenba@redhat.com
release note
/kind bug
fixes #59368