Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cluster Autoscaler version to 1.13.0-rc.2 #71452

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Update Cluster Autoscaler version to 1.13.0-rc.2 #71452

merged 1 commit into from
Nov 27, 2018

Conversation

losipiuk
Copy link
Contributor

This PR updates CA version in gce manifests to 1.13.0-rc.2.

We need to merge it during freeze because, Cluster Autoscaler imports large amount of k8s code to simulate scheduler behavior, yet it lives in separate repository. Therefore
we need to build final release candidate just at the end of k8s release cycle.

Update Cluster Autoscaler version to 1.13.0-rc.2. Release notes: /~https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.13.0-rc.2

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 27, 2018
@k8s-ci-robot k8s-ci-robot requested review from bowei and gmarek November 27, 2018 12:05
@losipiuk
Copy link
Contributor Author

/sig autoscaling
/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 27, 2018
@losipiuk
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2018
@losipiuk
Copy link
Contributor Author

@mwielgus please approve.
I put it on hold for now and let the sig-release that we want to merge this one on slack.

@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018
@mwielgus
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2018
@mwielgus mwielgus added this to the v1.13 milestone Nov 27, 2018
AishSundar
AishSundar reviewed Nov 27, 2018
View reviewed changes
cluster/gce/manifests/cluster-autoscaler.manifest
@@ -17,7 +17,7 @@
"containers": [
{
"name": "cluster-autoscaler",
"image": "k8s.gcr.io/cluster-autoscaler:v1.12.0",
"image": "k8s.gcr.io/cluster-autoscaler:v1.13.0-rc.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this version of 1.13 is still not built and tagged. is that alright?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already released.
see http://gcr.io/google-containers/cluster-autoscaler:v1.13.0-rc.2.

I also tried to pull the aliased k8s.gcr.io/cluster-autoscaler:v1.13.0-rc.2 and it worked

@AishSundar
Copy link
Contributor

@losipiuk I just had 1 comment relating to the version you are updating to. Otherwise LGTM. Feel free to remove hold when you are ready

@losipiuk
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit 414cfbd into kubernetes:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AishSundar AishSundar AishSundar left review comments

@bowei bowei Awaiting requested review from bowei

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
4 participants
@losipiuk @mwielgus @k8s-ci-robot @AishSundar